Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rasterize-email-unique-file #37323

Merged
merged 17 commits into from
Nov 26, 2024
Merged

rasterize-email-unique-file #37323

merged 17 commits into from
Nov 26, 2024

Conversation

tkatzir
Copy link
Contributor

@tkatzir tkatzir commented Nov 20, 2024 •
edited by MosheEichler
Loading

@tkatzir tkatzir requested a review from anara123 November 20, 2024 13:58
@tkatzir tkatzir marked this pull request as ready for review November 20, 2024 13:58
@tkatzir tkatzir requested a review from ilaredo as a code owner November 20, 2024 13:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/rasterize/Integrations/rasterize
   rasterize.py4617084%75–77, 84–86, 92–94, 134, 149–151, 154–156, 159, 162–164, 168–170, 182–183, 187–188, 192–193, 214–216, 227, 243–244, 276–281, 301, 360, 454–455, 458–461, 463, 607–609, 834–836, 846–847, 850, 893, 908–909, 934, 936–937, 947, 954–957
TOTAL4617084% 

Tests Skipped Failures Errors Time
129 0 💤 0 ❌ 0 🔥 2m 59s ⏱️

@MosheEichler MosheEichler self-assigned this Nov 24, 2024
tkatzir
tkatzir commented Nov 24, 2024
View reviewed changes
Copy link
Contributor Author

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
See comments.

Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
Packs/rasterize/Integrations/rasterize/rasterize.py Outdated Show resolved Hide resolved
@MosheEichler MosheEichler removed the request for review from ikatzpan November 24, 2024 10:08
@MosheEichler
Copy link
Contributor

@DeanArbel
Need a force merge.
Ticket.

@MosheEichler MosheEichler added the ForceMerge Forcing the merge of the PR despite the build status label Nov 26, 2024
@DeanArbel DeanArbel merged commit ba57df4 into master Nov 26, 2024
19 of 20 checks passed
@DeanArbel DeanArbel deleted the rasterize-email-unique-file branch November 26, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheEichler MosheEichler MosheEichler approved these changes

@anara123 anara123 Awaiting requested review from anara123

@ilaredo ilaredo Awaiting requested review from ilaredo ilaredo is a code owner

Assignees

@MosheEichler MosheEichler

Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkatzir @MosheEichler @ilaredo @DeanArbel